Discussion:
[O] Does :block field of clocktable respect org-extend-today-until?
Robert Irelan
2018-04-17 05:51:15 UTC
Permalink
Testing it just now, it appears that it doesn't - the clock table excludes
times after midnight but before org-extend-today-until. I'll probably work
on fixing this unless someone believes that the current version of org-mode
is expected to respect org-extend-today-until. org-version gives:
Org mode version 9.1.9 (9.1.9-8-gf05c2e-elpaplus)
Nicolas Goaziou
2018-04-17 12:54:53 UTC
Permalink
Hello,
Post by Robert Irelan
Testing it just now, it appears that it doesn't - the clock table excludes
times after midnight but before org-extend-today-until. I'll probably work
on fixing this unless someone believes that the current version of org-mode
Org mode version 9.1.9 (9.1.9-8-gf05c2e-elpaplus)
As its docstring states:

IMPORTANT: This is a feature whose implementation is and likely will
remain incomplete.

IOW, nothing in Org is really expected to respect
`org-extend-today-until'. Patches welcome, of course.

Regards,
--
Nicolas Goaziou
Robert Irelan
2018-05-01 00:30:39 UTC
Permalink
I have a patch to fix this in https://github.com/telotortium/org-mode
(branch org-clock-table-extend-today-until-block). I've submitted a
copyright assignment with the FSF.
Post by Nicolas Goaziou
Hello,
Post by Robert Irelan
Testing it just now, it appears that it doesn't - the clock table excludes
times after midnight but before org-extend-today-until. I'll probably work
on fixing this unless someone believes that the current version of org-mode
Org mode version 9.1.9 (9.1.9-8-gf05c2e-elpaplus)
IMPORTANT: This is a feature whose implementation is and likely will
remain incomplete.
IOW, nothing in Org is really expected to respect
`org-extend-today-until'. Patches welcome, of course.
Regards,
--
Nicolas Goaziou
--
Robert Irelan
***@gmail.com
Bastien
2018-05-01 08:11:02 UTC
Permalink
Hi Robert,
Post by Robert Irelan
I have a patch to fix this in https://github.com/telotortium/org-mode
(branch org-clock-table-extend-today-until-block). I've submitted a
copyright assignment with the FSF.
I confirm your copyright assignment is okay.

Can you send a patch against Org's current master branch?

Thanks!
--
Bastien
Robert Irelan
2018-05-01 19:40:39 UTC
Permalink
I've updated my repo at https://github.com/telotortium/org-mode (branch
org-clock-table-extend-today-until-block). (I know I cloned it from an older
org-mode repo on Github, but I've updated it so that my branch is rebased
onto
the current master.) I hope that'll work.
Post by Bastien
Hi Robert,
Post by Robert Irelan
I have a patch to fix this in https://github.com/telotortium/org-mode
(branch org-clock-table-extend-today-until-block). I've submitted a
copyright assignment with the FSF.
I confirm your copyright assignment is okay.
Can you send a patch against Org's current master branch?
Thanks!
--
Bastien
--
Robert Irelan
***@gmail.com
Robert Irelan
2018-05-07 17:43:24 UTC
Permalink
Hi, is there anything else I should do on this patch?
Post by Robert Irelan
I've updated my repo at https://github.com/telotortium/org-mode (branch
org-clock-table-extend-today-until-block). (I know I cloned it from an older
org-mode repo on Github, but I've updated it so that my branch is rebased
onto
the current master.) I hope that'll work.
Post by Bastien
Hi Robert,
Post by Robert Irelan
I have a patch to fix this in https://github.com/telotortium/org-mode
(branch org-clock-table-extend-today-until-block). I've submitted a
copyright assignment with the FSF.
I confirm your copyright assignment is okay.
Can you send a patch against Org's current master branch?
Thanks!
--
Bastien
--
Robert Irelan
--
Robert Irelan
***@gmail.com
Robert Irelan
2018-05-07 18:23:11 UTC
Permalink
I've rebased against latest master and attached the patch.
Post by Nicolas Goaziou
Hello,
Post by Robert Irelan
Hi, is there anything else I should do on this patch?
Would you mind sending it to the ML? It easier, at least for me, to
review or apply.
Thank you.
Regards,
--
Nicolas Goaziou 0x80A93738
--
Robert Irelan
***@gmail.com
Loading...